tests: housekeeping, test_ldap.py #7506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
force-pushed
the
cherry-pick-test-ldap
branch
from
28ab2f3
to
428e0b2
Compare
danlavu
force-pushed
the
cherry-pick-test-ldap
branch
from
428e0b2
to
d206c65
Compare
alexey-tikhonov
requested review from
shridhargadekar,
aplopez,
jakub-vavra-cz and
alexey-tikhonov
and removed request for
alexey-tikhonov
|
@danlavu, doesn't this de-sync 'master' and 'sssd-2-9' branches? |
|
Yes, the ppolicy feature is not available in 2-9. Now, master contains
that we can skip the tests and leave the un-used test code. Do we want to remove it from 2-9 or add the marker to skip the tests in this branch? |
housekeeping, the following is looked at and may have been done: * fixed typos and standardized formatting * renamed test cases to improve the clarity of what the test does * improved docstring language, setup, steps and expected results * synced code with the docstring order * removed necessary configuration relevant to the test * added pytest.mark.importance to test cases noteable changes: * removed lookup_user_default_naming_context_and_no_search_base because it is already covered by another test scenario added description to ppolicy tests, providing an explanation * removed enumeration configuration from tests where enumeration is not being tested * removed test case checking log messages for timeout Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Anuj Borah <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]> (cherry picked from commit 8c19d7b)
danlavu
force-pushed
the
cherry-pick-test-ldap
branch
from
d206c65
to
6d807ec
Compare
|
I spoke to Jakub. It will be harder to maintain if we drop these tests, so I've added them back in. You can see the tests are skipped for this branch. |
andreboscatto
requested review from
alexey-tikhonov
and removed request for
jakub-vavra-cz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
housekeeping, the following is looked at and may have been done:
noteable changes:
Reviewed-by: Alejandro López [email protected]
Reviewed-by: Anuj Borah [email protected]
Reviewed-by: Shridhar Gadekar [email protected]
(cherry picked from commit 8c19d7b)