tests: housekeeping - netgroups #7491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I'll review this once #7490 is merged, to avoid multiple iterations. |
danlavu
force-pushed
the
tests-housekeeping-netgroups
branch
2 times, most recently
from
96219cf
to
c0d7d0d
Compare
shridhargadekar
approved these changes
Jul 16, 2024
danlavu
force-pushed
the
tests-housekeeping-netgroups
branch
2 times, most recently
from
cf79fdf
to
e74abf2
Compare
danlavu
force-pushed
the
tests-housekeeping-netgroups
branch
2 times, most recently
from
295d0a2
to
835f99c
Compare
|
@danlavu, please rebase/resolve conflict. |
housekeeping, the following is looked at and may have been done: * fixed typos and standardized formatting * renamed test cases to improve the clarity of what the test does * improved docstring language, setup, steps and expected results * synced code with the docstring order * removed necessary configuration relevant to the test * added pytest.mark.importance to test cases * added error messages to assertions noteable changes: * moved netgroup tests to the the cache tests file, it tests the cache for netgroup objects
danlavu
force-pushed
the
tests-housekeeping-netgroups
branch
from
835f99c
to
b454510
Compare
|
Hi Dan, the three changes to test_cache.py that just adds the importance marker should go in separate commit since they have nothing in common with netgroups. I personally don't like the idea of adding everything into test_cache.py. SSSD's primary function is to cache stuff, therefore this file will grow too much over the time. I think it makes perfect sense to split it into objects own modules like test_netgroup.py. |
|
@pbrezina this was an oversight on my part. There is another netgroup test in cache and I thought these were those. Where it specifically looked in the ldb cache for the netgroup object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
housekeeping, the following is looked at and may have been done:
noteable changes:
for netgroup objects