Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: housekeeping, test_files.py #7463

Closed
wants to merge 1 commit into from
Closed

tests: housekeeping, test_files.py #7463

wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Jun 27, 2024

  • fixed typos and standardized formatting

  • renamed test cases to improve the clarity of what the test does

  • improved docstring language, setup, steps and expected results

  • added pytest.mark.importance to test cases

  • the tests are simple, removed the error messages

  • root lookup test updated with an additional assertion

@danlavu danlavu self-assigned this Jun 27, 2024
@danlavu
Copy link
Author

danlavu commented Jun 27, 2024

Passing

============================= test session starts ==============================
collecting ... 

Selected tests will use the following hosts:
  client: client.test
  kdc: kdc.test

collected 560 items / 556 deselected / 4 selected

tests/test_files.py::test_files__get_entry_using_sss_service_should_not_work_looking_for_root (client) 
tests/test_files.py::test_files__lookup_user (client) 
tests/test_files.py::test_files__enumeration_should_not_work (client) 
tests/test_files.py::test_files__lookup_returns_the_latest_data (client) 

====================== 4 passed, 556 deselected in 14.38s ======================
PASSED [ 25%]PASSED             [ 50%]PASSED [ 75%]PASSED [100%]
Process finished with exit code 0

@danlavu danlavu force-pushed the tests-housekeeping-tests_files_py branch from f7a426e to 24c9e6a Compare June 27, 2024 09:59
@danlavu danlavu force-pushed the tests-housekeeping-tests_files_py branch from 24c9e6a to 5144a44 Compare June 28, 2024 18:36
jakub-vavra-cz
jakub-vavra-cz approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danlavu danlavu force-pushed the tests-housekeeping-tests_files_py branch from 5144a44 to b139d2d Compare July 11, 2024 13:29
sumit-bose
sumit-bose approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the update, ACK.

bye,
Sumit

@danlavu danlavu force-pushed the tests-housekeeping-tests_files_py branch from b139d2d to 61ca705 Compare July 12, 2024 02:34
@danlavu danlavu added the Ready to push Ready to push label Jul 12, 2024
tests: housekeeping, test_files.py
2fe3ed4 
* fixed typos and standardized formatting
* renamed test cases to improve the clarity of what the test does
* improved docstring language, setup, steps and expected results
* added pytest.mark.importance to test cases
* the tests are simple, removed the error messages

* root lookup test updated with an additional assertion
@danlavu danlavu force-pushed the tests-housekeeping-tests_files_py branch from 61ca705 to 2fe3ed4 Compare July 23, 2024 18:51
@danlavu
Copy link
Author

danlavu commented Jul 23, 2024

tests are passing, copr build fail for c9 and fedora 40

@alexey-tikhonov alexey-tikhonov added Ready to push Ready to push and removed Ready to push Ready to push labels Jul 24, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7463

  • master
    • f70411a - tests: housekeeping, test_files.py
  • sssd-2-9
    • 998d183 - tests: housekeeping, test_files.py

@danlavu danlavu deleted the tests-housekeeping-tests_files_py branch November 4, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes

@sumit-bose sumit-bose sumit-bose approved these changes

Assignees

@sumit-bose sumit-bose

@jakub-vavra-cz jakub-vavra-cz

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danlavu @alexey-tikhonov @sumit-bose @jakub-vavra-cz