version: replace dash with tilda #7414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
approved these changes
Jun 7, 2024
We released a new SSSD beta version as 2.10.0-beta1, unfortunately this caused issues in the rpm build system as this value is set as the Version field but dash is not allowed in this field therefore `make rpms` was broken. Fedora guidelines requires to use ~ as a prerelease separator so two NVR versions compare correctly. For example: * 2.10.0 < 2.10.0-beta1 * 2.10.0~beta1 < 2.10.0 We will follow this guideline to make `make rpms` work again and to avoid any further rpm issues. Next GitHub release will also follow this guideline.
|
@sumit-bose @alexey-tikhonov this is ready for review, failures are unrelated. |
sumit-bose
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Hi,
thanks, I'm fine with the changes, so ACK.
But wouldn't it be more easy to have this and the patch from #7415 in a single PR which would hopefully have a green CI run?
bye,
Sumit
This does not work on Fedora 41, it looks like it is not supported by dnf5.
|
Ok, I moved it here. |
|
About dnf: looks like it's a confirmed bug - rpm-software-management/dnf5#700 |
| elif [[ "$DISTRO_BRANCH" == -redhat-* ]]; then | ||
| [ $# != 0 ] && sudo -p "$prompt" yum --assumeyes install -- "$@" |& | ||
| [ $# != 0 ] && sudo -p "$prompt" yum --assumeyes install "$@" |& |
There was a problem hiding this comment.
btw, 'yum' is deprecated since RHEL9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We released a new SSSD beta version as 2.10.0-beta1, unfortunately
this caused issues in the rpm build system as this value is set as
the Version field but dash is not allowed in this field therefore
make rpmswas broken.Fedora guidelines requires to use ~ as a prerelease separator so
two NVR versions compare correctly. For example:
We will follow this guideline to make
make rpmswork again andto avoid any further rpm issues. Next GitHub release will also
follow this guideline.