Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: alltests/test_krb5: Remove files provider #7194

Closed
wants to merge 1 commit into from
Closed

Tests: alltests/test_krb5: Remove files provider #7194

wants to merge 1 commit into from

Conversation

madhuriupadhye
Copy link
Contributor

@madhuriupadhye madhuriupadhye commented Feb 15, 2024 •
edited
Loading

Replace files provider with proxy provider.
This test case test authentication of local user using
KDC and also update the authselect to select sssd only.

@madhuriupadhye madhuriupadhye added Tests no-backport This should go to target branch only. labels Feb 15, 2024
@alexey-tikhonov
Copy link
Member

This test is about local users (from /etc/passwd) that authenticate using kerberos.
It makes perfect sense in general, as was discussed with @shridhargadekar
I don't know if it's better to drop this test and create new (using proxy provider), or is it better to port this test.
It's up to you to decided.
But test case should be covered.

@madhuriupadhye madhuriupadhye marked this pull request as draft February 15, 2024 16:08
@madhuriupadhye madhuriupadhye marked this pull request as ready for review February 16, 2024 12:48
danlavu
danlavu approved these changes Feb 20, 2024
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@shridhargadekar
Copy link
Contributor

@danlavu review the newly added changes.

danlavu
danlavu approved these changes Mar 13, 2024
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

danlavu
danlavu approved these changes Mar 15, 2024
View reviewed changes
Copy link

@danlavu danlavu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M, just rebase.

@madhuriupadhye
Tests: alltests/test_krb5: Replace files provider
cf589fb 
Replace files provider with proxy provider.
This test case test authentication of local user using
kerberos and also update the authselect to select sssd only.

Signed-off-by: Madhuri Upadhye <[email protected]>
@jakub-vavra-cz jakub-vavra-cz added backport-to-stable Ready to push Ready to push and removed no-backport This should go to target branch only. labels Mar 21, 2024
@jakub-vavra-cz
Copy link
Contributor

Pushed PR: #7194

  • master
    • 0b26b6f - Tests: alltests/test_krb5: Replace files provider
  • sssd-2-9
    • 57a8fff - Tests: alltests/test_krb5: Replace files provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlavu danlavu danlavu approved these changes

Assignees

@danlavu danlavu

Labels
Pushed Tests Trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madhuriupadhye @alexey-tikhonov @shridhargadekar @jakub-vavra-cz @danlavu