UTILS: remove unused code (files manipulations) #6894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
Waiting for review
no-backport
ikerexxe
approved these changes
Aug 22, 2023
alexey-tikhonov
force-pushed
the
clear-files
branch
from
d4dfb98
to
196f024
Compare
|
(just a rebase) |
Hi, it looks like to code was taken from shadow-utils and there is still code left in functions which are still used so we should keep the notice. Compare e.g. shadow-utils' bye, |
sumit-bose
approved these changes
Aug 25, 2023
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most probably copyright notice ("This file incorporates work covered...") can also be removed as corresponding code was removed, but I'm not entirely sure.