Passkey: Add child timeout handler #6893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
added
backport-to-stable
passkey
|
Please add "Resolves:" line. |
justin-stephenson
force-pushed
the
passkey_timeout_fix
branch
from
8f4947a
to
da4f62b
Compare
Done. |
sumit-bose
reviewed
Aug 29, 2023
src/responder/pam/pamsrv_passkey.c
Outdated
| struct pam_passkey_auth_send_state *state = | ||
| tevent_req_data(req, struct pam_passkey_auth_send_state); | ||
|
|
||
| DEBUG(SSSDBG_CRIT_FAILURE, "Timeout reached for passkey child\n"); |
There was a problem hiding this comment.
Hi,
since there is the passkey_child_timeout option, what do you think about mention it here, e.g. similar to p11_child_timeout().
bye,
Sumit
There was a problem hiding this comment.
Agreed, updated.
sumit-bose
reviewed
Aug 29, 2023
src/responder/pam/pamsrv_passkey.c
Outdated
| child_handler_destroy(state->child_ctx); | ||
| state->child_ctx = NULL; | ||
| state->child_status = ETIMEDOUT; | ||
| tevent_req_error(req, ERR_PASSKEY_CHILD); |
There was a problem hiding this comment.
Hi,
I think it is worth to add a dedicated ERR_PASSKEY_CHILD_TIMEOUT error code her.
bye,
Sumit
justin-stephenson
force-pushed
the
passkey_timeout_fix
branch
from
da4f62b
to
22821a6
Compare
If passkey auth times out, the SIGCHLD handler needs to be destroyed otherwise the SIGCHLD handler tries to access the tevent_req which was already freed from the timeout. Resolves: SSSD#6889
justin-stephenson
force-pushed
the
passkey_timeout_fix
branch
from
22821a6
to
26c1ca3
Compare
sumit-bose
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passkey auth times out, the SIGCHLD handler needs to be destroyed otherwise the SIGCHLD handler tries to access the
tevent_req *reqwhich was already freed from the timeout.This can be reproduced with
localpasskey auth - after entering a PIN don't press the passkey device tactile trigger, invoking the passkey child timeout.