Skip to content

Commit

Permalink
RESOLV: supress deprecation warnings
Browse files Browse the repository at this point in the history
In theory new API might be somewhat better.

But:

1) it's fairly new: `ares_search_dnsrec()` and `ares_query_dnsrec()`
were introduced in c-ares-1.28 while even CentOS Stream 10 has
c-ares-1.25, so SSSD would need to support (fallback) old API anyway.

2) SSSD doesn't make heavy use of DNS, so potential performance
improvements are really negligible.

On the other hand, old API/ABI will be available for a long time:
c-ares/c-ares#732 (comment)

For those reasons it's not worth the effort to port code to new API
right now.
  • Loading branch information
alexey-tikhonov committed Sep 11, 2024
1 parent 13fd018 commit 992366c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion src/resolv/async_resolv.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include <arpa/inet.h>
#include <arpa/nameser.h>

#include <ares.h>
#include <talloc.h>
#include <tevent.h>

Expand Down
1 change: 1 addition & 0 deletions src/resolv/async_resolv.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#define __ASYNC_RESOLV_H__

#include <netdb.h>
#define CARES_NO_DEPRECATED
#include <ares.h>

#include "config.h"
Expand Down

0 comments on commit 992366c

Please sign in to comment.