-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils sssd, adding clean flag, clearing the cache on starts and restarts #136
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would not use None for the clean as it dowes not make a sense to me.
Maybe the clean should be default True? (no strong opinion there)
ed5b683
to
0c2c3fb
Compare
0c2c3fb
to
f319195
Compare
We would have to refactor the cache tests to set it to false. Let's minimize changing the behavior of existing methods. |
Ok, then it makes a sense to keep it False . Disregard my previous comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e7a8b92
to
577b3fd
Compare
577b3fd
to
b2d1d3f
Compare
b2d1d3f
to
3ebcfc1
Compare
Two commits:
to