Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils sssd, adding clean flag, clearing the cache on starts and restarts #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danlavu
Copy link

@danlavu danlavu commented Nov 5, 2024

Two commits:

  1. Adding a clean parameter to mkhomedir common configuration, the override_homedirs are failing because some directories already exist from other tests. After backing up homedir path, it will not clear it as well.
  2. Adding a clean parameter to sssd start, restart to condense
client.sssd.stop()
client.sssd.clear()
client.sssd.start()

to

client.sssd.restart(clean=True)

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would not use None for the clean as it dowes not make a sense to me.
Maybe the clean should be default True? (no strong opinion there)

@danlavu
Copy link
Author

danlavu commented Nov 12, 2024

Looks good, I would not use None for the clean as it dowes not make a sense to me. Maybe the clean should be default True? (no strong opinion there)

We would have to refactor the cache tests to set it to false. Let's minimize changing the behavior of existing methods.

@jakub-vavra-cz
Copy link
Contributor

Looks good, I would not use None for the clean as it dowes not make a sense to me. Maybe the clean should be default True? (no strong opinion there)

We would have to refactor the cache tests to set it to false. Let's minimize changing the behavior of existing methods.

Ok, then it makes a sense to keep it False . Disregard my previous comment.

jakub-vavra-cz
jakub-vavra-cz previously approved these changes Nov 14, 2024
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jakub-vavra-cz
jakub-vavra-cz previously approved these changes Nov 25, 2024
sssd_test_framework/hosts/client.py Outdated Show resolved Hide resolved
sssd_test_framework/utils/sssd.py Outdated Show resolved Hide resolved
sssd_test_framework/utils/sssd.py Outdated Show resolved Hide resolved
sssd_test_framework/utils/sssd.py Outdated Show resolved Hide resolved
sssd_test_framework/utils/sssd.py Outdated Show resolved Hide resolved
sssd_test_framework/utils/sssd.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants