Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak: add KC_HTTPS_TRUST_STORE_TYPE #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sumit-bose
Copy link
Contributor

It looks like recent version of keycloak require that the
KC_HTTPS_TRUST_STORE_TYPE environment variable is set. Otherwise an
error like "kc.sh[54]: Unable to determine 'https-trust-store-type'
automatically. Adjust the file extension or specify the property." might
occur and keycloak fails to start.

It looks like recent version of keycloak require that the
KC_HTTPS_TRUST_STORE_TYPE environment variable is set. Otherwise an
error like "kc.sh[54]: Unable to determine 'https-trust-store-type'
automatically. Adjust the file extension or specify the property." might
occur and keycloak fails to start.
@sumit-bose
Copy link
Contributor Author

Hi,

it looks like in recent version of keycloak KC_HTTPS_TRUST_STORE_FILE, KC_HTTPS_TRUST_STORE_PASSWORD and KC_HTTPS_TRUST_STORE_TYPE are deprecated in favor of System Truststore.

Additionally there are the messages

Oct 25 12:41:25 master.keycloak.test kc.sh[304]: 2024-10-25 12:41:25,881 WARN  [org.keycloak.services] (main) KC-SERVICES0110: Environment variable 'KEYCLOAK_ADMIN' is deprecated, use 'KC_BOOTSTRAP_ADMIN_USERNAME' instead
Oct 25 12:41:25 master.keycloak.test kc.sh[304]: 2024-10-25 12:41:25,881 WARN  [org.keycloak.services] (main) KC-SERVICES0110: Environment variable 'KEYCLOAK_ADMIN_PASSWORD' is deprecated, use 'KC_BOOTSTRAP_ADMIN_PASSWORD' instead

asking to change KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD as well.

Since I wasn't sure about backwards compatibility I only added KC_HTTPS_TRUST_STORE_TYPE for the time being but I can prepare an additional pull-request with the other changes if needed as well.

bye,
Sumit

Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ipa-tuura deployment we execute:

keytool -importcert -alias bridge -file /opt/keycloak/bridge.crt -keystore /opt/keycloak/keystore.jks -trustcacerts -storepass redhat -noprompt

Maybe it is enough to change the keystore file to have .jks filename extension?

@sumit-bose
Copy link
Contributor Author

In ipa-tuura deployment we execute:

keytool -importcert -alias bridge -file /opt/keycloak/bridge.crt -keystore /opt/keycloak/keystore.jks -trustcacerts -storepass redhat -noprompt

Maybe it is enough to change the keystore file to have .jks filename extension?

Hi,

yes, this works for me as well, not sure what would be the preferable solution.

bye,
Sumit

@justin-stephenson
Copy link
Contributor

In ipa-tuura deployment we execute:

keytool -importcert -alias bridge -file /opt/keycloak/bridge.crt -keystore /opt/keycloak/keystore.jks -trustcacerts -storepass redhat -noprompt

Maybe it is enough to change the keystore file to have .jks filename extension?

Hi,

yes, this works for me as well, not sure what would be the preferable solution.

bye, Sumit

I'm fine with either approach, Ack.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants