Skip to content

Commit

Permalink
Remove python=3.8 from testing (not supported by latest pymatgen,…
Browse files Browse the repository at this point in the history
… though vast majority of `doped` features can still work with `3.8`)
  • Loading branch information
kavanase committed Nov 21, 2023
1 parent 7381a9e commit 656468c
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pip_install_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false

matrix:
python-version: [ '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '3.9', '3.10', '3.11' ]
os: [ ubuntu-latest ]

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false

matrix:
python-version: [ '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '3.9', '3.10', '3.11' ]
os: [ ubuntu-latest ]

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ version: 2
build:
os: ubuntu-20.04
tools:
python: "3.8"
python: "3.9"

# Build from the docs/ directory with Sphinx
sphinx:
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@

# Example configuration for intersphinx: refer to the Python standard library.
intersphinx_mapping = {
"python": ("https://docs.python.org/3.8", None),
"python": ("https://docs.python.org/3.9", None),
"numpy": ("http://docs.scipy.org/doc/numpy/", None),
"pymatgen": ("http://pymatgen.org/", None),
"matplotlib": ("http://matplotlib.org", None),
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ classifiers = [
"Topic :: Scientific/Engineering :: Chemistry",
"Topic :: Software Development :: Libraries :: Python Modules",
]
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = [
"tabulate",
"matplotlib>=3.5.2",
Expand Down
7 changes: 1 addition & 6 deletions tests/test_vasp.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import locale
import os
import random
import sys
import unittest
import warnings

Expand Down Expand Up @@ -66,7 +65,7 @@ def _check_no_potcar_available_warning_error(symbol, message):
x in str(message)
for x in [
f"No POTCAR for {symbol} with functional",
"Please set the PMG_VASP_PSP_DIR", # message differs slightly for python 3.8 vs >=3.9
"Please set the PMG_VASP_PSP_DIR",
]
)

Expand Down Expand Up @@ -1166,14 +1165,10 @@ def test_write_files_defect_entry_list(self):
check_potcar_spec=True,
)

@unittest.skipIf(sys.version_info[:2] == (3, 8), "Test is skipped for Python 3.8")
def test_initialise_and_write_all_defect_gens(self):
"""
Test initialising DefectsSet with our generation-tests materials, and
writing files to disk.
Hangs on GitHub Actions python=3.8 for some reason, so skipped if we're
on python=3.8.
"""
for defect_gen_name in [
"ytos_defect_gen",
Expand Down

0 comments on commit 656468c

Please sign in to comment.