Skip to content

Development Process

Gyeonghwan Hong edited this page Dec 4, 2017 · 1 revision

The following guidelines on the development process are provided to help you be more effective when developing patches on the ANT framework project.

Pull Request

When your development is completed, a patch set should be submitted via Github pull requests. When you submit your pull request, you'd better to create a separated branch on your repository(ex. developing branch).

Vote

After you upload the pull request, reviews of its patch set will take place. Project maintainers or committers on the source code will make reviews.

If 2 or more reviewers agree with your review, your pull request will be accepted and merged to the main branches. If not, you have to make a change on your patches to fulfill the reviewer's suggestion (soft reject). If your pull request is not acceptable to this project, it can be rejected (hard reject).

Code Review

Code review can be performed by all the members of the project (not just maintainers and committers). Members can review code changes and share their opinion by comments with the following principles.

  • Discuss code; never discuss the code's author.
  • Respect and acknowledge contributions, suggestions, and comments.
  • Listen and be open to all different opinions.
  • Help each other.

Branches

ANT framework maintains a single main branch named as master. Sometime it can have more child branches to proceed sub-projects, and some pull requests can be issued for those branches.