Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements/environment #169

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

Will-Cooper
Copy link
Member

closes #141, simplify requirements.txt and environment.yml, swap mult…multiprocessing for multiprocess to work on Mac.
Can test with:

conda env create --name simpletest -f environment.yml
conda activate simpletest
python -m simple_app.app_simple
conda deactivate
conda env remove -n simpletest

…yml, swap multiprocessing for multiprocess to work on Mac
@Will-Cooper Will-Cooper added documentation Improvements or additions to documentation meta Meta changes for git/pip/conda issues labels Jan 30, 2024
@Will-Cooper Will-Cooper self-assigned this Jan 30, 2024
@dr-rodriguez
Copy link
Collaborator

I like the simplification, but we should considering pinning the requirement versions, especially since this is the website. The general user can grab the latest, but the website should have pinned versions or an update can break it.

@Will-Cooper
Copy link
Member Author

I agree, I'm also considering upgrading the python version on the website to get ahead of the game. Just need to do some fixes as there's several changes in pandas etc.

@Will-Cooper Will-Cooper marked this pull request as draft January 31, 2024 15:29
environment.yml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@Will-Cooper Will-Cooper marked this pull request as ready for review March 19, 2024 20:58
@Will-Cooper Will-Cooper merged commit 938df6e into SIMPLE-AstroDB:main Mar 19, 2024
4 checks passed
@Will-Cooper Will-Cooper deleted the updates branch March 19, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation meta Meta changes for git/pip/conda issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update requirements.txt
2 participants