Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest file for BDR_J1750+3809 #426

Merged
merged 8 commits into from
Dec 4, 2023
Merged

Ingest file for BDR_J1750+3809 #426

merged 8 commits into from
Dec 4, 2023

Conversation

LishaRamon
Copy link
Collaborator

@LishaRamon LishaRamon commented Nov 30, 2023 •
edited
Loading

Some of the data of BDR_J1750+3809 that are being ingested in this script are publications, sources, and names.

Link to relevant issue: Closes #393

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@kelle
Copy link
Collaborator

kelle commented Dec 4, 2023

Decided not to update the Versions table just yet. Lets do some more ingests before planning a new release.

@LishaRamon LishaRamon requested a review from kelle December 4, 2023 20:57
kelle
kelle approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LishaRamon LishaRamon merged commit 578ba1e into SIMPLE-AstroDB:main Dec 4, 2023
1 check passed
@LishaRamon LishaRamon deleted the Third branch December 4, 2023 21:01
@kelle kelle added this to the 2023.4 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelle kelle kelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.4
Development

Successfully merging this pull request may close these issues.

Ingest BDR J1750+3809
2 participants
@LishaRamon @kelle