Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrizing the photometry tests for clearer updates #407

Merged

Conversation

dr-rodriguez
Copy link
Collaborator

Rework one of the tests for easier updates. We can probably apply this strategy to other tests, but for now just on photometry.

Closes #406

@dr-rodriguez dr-rodriguez requested a review from kelle September 26, 2023 20:52
@dr-rodriguez dr-rodriguez self-assigned this Sep 26, 2023
Copy link
Member

@Will-Cooper Will-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's pin this as the optimal way of testing lots of the same thing

@dr-rodriguez dr-rodriguez merged commit 461aa0c into SIMPLE-AstroDB:main Oct 17, 2023
1 check passed
@kelle kelle added this to the 2023.3 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework test_data to parametrize testing photometry
3 participants