-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for spectrum urls #404
Conversation
My worry is that this may be attempting to fetch thousands of spectra for each time the tests runs, which is why it takes a longer time. |
YES! Here's how to do it: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule What should we call the file? still test_? If we do that, it will be run by default by pytest. So maybe a different name? |
We could change the pytest defaults, or just call it something like scheduled_jobs.py or something similar |
scheduled_tests? |
I don't know if the pytest defaults look at anything that starts with |
Here's the documentation for pytest autodiscovery: My first choice is to make a file/test which just doesn't get auto-discovered but still lives in |
This is ready for re-review. It's just the tests. Once it's merged, I'd like to run the action, make sure it works with all the broken URLs. Then I can work on #409 to actually fix the URLs. |
New test to make sure spectrum urls don't give 404. This test takes some time....not sure we want to keep it, but it's useful at the moment. Related to #347.
Link to relevant issue: Closes #369