More robust ausearch time input #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on what locale you were using, you may have time that would show AM or PM. This would cause the time to be incorrect on noon and midnight rollovers. This change allows all the output of strptime's %x and %X to be captured and provided to ausearch.
|
I don't know why my email response to the thread isn't showing. Did you post this to the selinux list, i didn't see it? If you didn't please send it to the list as well. |
williamcroberts
approved these changes
Mar 13, 2019
|
Did you post this to the mailing list, I am not seeing it. I have no objections,
But we require the patch on the mailing list. However, issuing a PR makes
My life easier, thanks.
… -----Original Message-----
From: Kenny Root ***@***.***
Sent: Tuesday, March 12, 2019 7:35 PM
To: SELinuxProject/selinux ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [SELinuxProject/selinux] More robust ausearch time input (#135)
Depending on what locale you were using, you may have time that would show
AM or PM.
This would cause the time to be incorrect on noon and midnight rollovers. This
change allows all the output of strptime's %x and %X to be captured and provided
to ausearch.
________________________________
You can view, comment on, or merge this pull request online at:
#135
Commit Summary
* More robust ausearch time input
File Changes
* M python/sepolicy/sepolicy/templates/script.py
<https://github.com/SELinuxProject/selinux/pull/135/files#diff-0> (5)
Patch Links:
* https://github.com/SELinuxProject/selinux/pull/135.patch
* https://github.com/SELinuxProject/selinux/pull/135.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#135> , or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AQ7bB24OkQ8Hsoz5bHQK3BrqJpP3_dDzks5vWGO7gaJpZM4bsRGJ> .
<https://github.com/notifications/beacon/AQ7bB8yuhNcg0XDX77wT-
f6Wn5IZAfYlks5vWGO7gaJpZM4bsRGJ.gif>
|
|
No, I was just annoyed when the time flipped from AM to PM. |
|
Can you send this patch out to the list? |
|
@kruton The patch needs to be sent to [email protected] for review. I can do it for you. But I'd like to ask you to add Signed-off-by: line (git commit -s ...) to the description, see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on what locale you were using, you may have time that would show AM or PM.
This would cause the time to be incorrect on noon and midnight rollovers. This change allows
all the output of strptime's %x and %X to be captured and provided to ausearch.