Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Score visibility #97

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Score visibility #97

merged 3 commits into from
Mar 12, 2024

Conversation

BramMeir
Copy link
Contributor

  • Possibility for teachers to set the visibility of scores for students
  • Score only visible for students that are part of the given group

@BramMeir BramMeir added this to the Backend milestone milestone Mar 12, 2024
@BramMeir BramMeir requested review from EwoutV and francisvaut March 12, 2024 16:33
@BramMeir BramMeir self-assigned this Mar 12, 2024
francisvaut
francisvaut reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@francisvaut francisvaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.
Perhaps we should also implement that teachers can only view the score of groups that are participating in his projects.
Edit: as it turns out, this is already the case.

@francisvaut francisvaut merged commit 700e7eb into development Mar 12, 2024
2 checks passed
@EwoutV EwoutV deleted the score-visibility branch March 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisvaut francisvaut francisvaut approved these changes

@EwoutV EwoutV Awaiting requested review from EwoutV

Assignees

@BramMeir BramMeir

Labels
None yet
Projects
None yet
Milestone
Backend milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BramMeir @francisvaut