Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: serializers for validation #68

Merged
merged 1 commit into from
Mar 9, 2024
Merged

chore: serializers for validation #68

merged 1 commit into from
Mar 9, 2024

Conversation

EwoutV
Copy link
Contributor

@EwoutV EwoutV commented Mar 8, 2024 •
edited
Loading

  • Refactored the course views so they all use serializers for validation. Goal is to separate validation from business logic.
  • Added extra checks for students joining/leaving courses that should not be in the past

closes #63

@EwoutV EwoutV added this to the Backend milestone milestone Mar 8, 2024
@EwoutV EwoutV self-assigned this Mar 8, 2024
BramMeir
BramMeir approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@BramMeir BramMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks better indeed to separate the validation.

@EwoutV EwoutV merged commit 19db3c7 into development Mar 9, 2024
2 checks passed
@EwoutV EwoutV deleted the course-logic branch March 9, 2024 09:04
@EwoutV EwoutV restored the course-logic branch March 9, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BramMeir BramMeir BramMeir approved these changes

@DeLany123 DeLany123 Awaiting requested review from DeLany123

@francisvaut francisvaut Awaiting requested review from francisvaut

Assignees

@EwoutV EwoutV

Labels
None yet
Projects
None yet
Milestone
Backend milestone
Development

Successfully merging this pull request may close these issues.

backend(api): check if year of course is not in the past when created
2 participants
@EwoutV @BramMeir