Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n api #59

Merged
merged 41 commits into from
Mar 13, 2024
Merged

I18n api #59

merged 41 commits into from
Mar 13, 2024

Conversation

bsilkyn
Copy link
Contributor

@bsilkyn bsilkyn commented Mar 7, 2024 •
edited
Loading

It would be handy if all API error messages got made available in a natural language if requested by the user (only english and dutch for now).

closes #100

@bsilkyn bsilkyn added this to the Backend milestone milestone Mar 7, 2024
@bsilkyn bsilkyn self-assigned this Mar 7, 2024
EwoutV
EwoutV reviewed Mar 8, 2024
View reviewed changes
backend/ypovoli/settings.py Outdated Show resolved Hide resolved
bsilkyn added 15 commits March 12, 2024 21:58
@bsilkyn
chore: rebase
bfa13d4
@bsilkyn
chore: (Dutch) folder structure helper + course serializer + group se…
d66ecc5 
…rializer + project serializer translation #100
@bsilkyn
chore: (Dutch) folder structure helper + course serializer + group se…
545a858 
…rializer + project serializer translation (now for real) #100
@bsilkyn
test: make authentication test names more professional
ead419c
@bsilkyn
chore: add available language translations #100
543903f
@bsilkyn
chore: course_view dutch translation + adaption to translation keys #100
4674614
@bsilkyn
chore: group_view and project_view Dutch translation #100
d5b865e
@bsilkyn
chore: remote merge #100
90db265
@bsilkyn
chore: English translation zip checks + course_serializer + group_ser…
9fde752 
…ializer #100
@bsilkyn
chore: English translation project_serializer #100
174ddff
@bsilkyn
chore: English translation course_view + group_view + project_view #100
8b65cd7
@bsilkyn
chore: slight adjustments #100
c773823
@bsilkyn
chore: adjustment to courses.error.students.past_course #100
dfda4a4
@bsilkyn
chore: adjustment to group.errors.full translation #100
7de8329
@bsilkyn
chore: translation remove spelling mistakes #100
6f434a7
@bsilkyn bsilkyn marked this pull request as ready for review March 13, 2024 12:15
@bsilkyn bsilkyn requested review from EwoutV and tyboro2002 March 13, 2024 12:15
bsilkyn and others added 19 commits March 13, 2024 19:35
@bsilkyn
chore: add available language translations #100
33734ad
@bsilkyn
chore: course_view dutch translation + adaption to translation keys #100
6ac3a1e
@bsilkyn
chore: group_view and project_view Dutch translation #100
c5e43bd
@bsilkyn
chore: another rebase #57
964e9bb
@bsilkyn
chore: English translation zip checks + course_serializer + group_ser…
6502aa4 
…ializer #100
@bsilkyn
chore: English translation project_serializer #100
b707646
@bsilkyn
chore: English translation course_view + group_view + project_view #100
c04a8fd
@bsilkyn
chore: slight adjustments #100
6095adf
@bsilkyn
chore: adjustment to courses.error.students.past_course #100
1bc43c2
@bsilkyn
chore: adjustment to group.errors.full translation #100
f7a71cb
@bsilkyn
chore: translation remove spelling mistakes #100
b113fd9
@bsilkyn
test: add little test #100
db3e97a
@bsilkyn
Merge branch 'i18n-api' of gitsel2:SELab-2/UGent-7 into i18n-api
90cb281
@bsilkyn
chore: fix for tests and linter #100
158043a
@francisvaut
build: compile .po files
3bb0483
@bsilkyn
test: fix test to be solely dependent on translation key, not transla…
4c27fba 
…tions #100
@bsilkyn
Merge branch 'development' into i18n-api
a8c6635
@bsilkyn
chore: translate extra translation keys from project logic #100
7555246
@francisvaut
fix: backend-tests.yaml
2b0b035
EwoutV
EwoutV approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@EwoutV EwoutV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 👌

@EwoutV EwoutV merged commit 1866e37 into development Mar 13, 2024
2 checks passed
@EwoutV EwoutV deleted the i18n-api branch March 13, 2024 23:57
@EwoutV EwoutV mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutV EwoutV EwoutV approved these changes

@tyboro2002 tyboro2002 Awaiting requested review from tyboro2002

Assignees

@bsilkyn bsilkyn

Labels
None yet
Projects
None yet
Milestone
Backend milestone
Development

Successfully merging this pull request may close these issues.

backend(api): make ValidationErrors in api app available in natural languages
4 participants
@bsilkyn @EwoutV @tyboro2002 @francisvaut