-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra checks #455
Fix extra checks #455
Conversation
BramMeir
commented
May 23, 2024
- Option to show the generated artifacts to the students
- Option to remove private docker images
- Fix new students join individual projects automatically
- Remove emojis after democratic decision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but I don't know what exactly goes wrong but when creating a project with multiple extra checks and different combinations for artifacts and logs visibilty, I get the following error:
ValueError: Field 'id' expected a number but got ''.
"POST /api/projects/4/extra_checks/ HTTP/1.0" 500 19216
Internal Server Error: /api/projects/4/extra_checks/
I see the issue, when you create multiple extra checks the form is reset. But by doing this, the docker image field is set to a default empty one. So when you don't select a docker image in the list, this passes the validation but will not work when making the request. I will fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🙌