Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tree view for project submission structure, cleanups #447

Merged
merged 15 commits into from
May 21, 2024
Merged

feat: tree view for project submission structure, cleanups #447

merged 15 commits into from
May 21, 2024

Conversation

EwoutV
Copy link
Contributor

@EwoutV EwoutV commented May 21, 2024 •
edited
Loading

  • Cleaned up the data fetching logic and loading states on all views
  • Added an interactive project structure builder for automatic checks
  • Improved the way in which forms worked: a single form component using a model
  • Better form error displayment

closes #382

@EwoutV EwoutV requested review from BramMeir and francisvaut May 21, 2024 12:20
Topvennie
Topvennie requested changes May 21, 2024
View reviewed changes
backend/api/logic/parse_zip_files.py Outdated Show resolved Hide resolved
backend/api/views/project_view.py Outdated Show resolved Hide resolved
backend/api/views/project_view.py Outdated Show resolved Hide resolved
backend/api/serializers/checks_serializer.py Outdated Show resolved Hide resolved
@francisvaut francisvaut mentioned this pull request May 21, 2024
Closed
DeLany123
DeLany123 reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@DeLany123 DeLany123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations are not working properly
image

backend/api/tests/test_file_structure.py Outdated Show resolved Hide resolved
@DeLany123
Copy link
Contributor

div moves when hovering "nieuwe map"
image

@DeLany123
Copy link
Contributor

When pressing add new map, when the previous one is still named as "new" nothing happens, this is very unclear for a user. I suggest you change this to a placeholder which tells the user to fill in a name for a map so this almost never occurs.
image

DeLany123
DeLany123 reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@DeLany123 DeLany123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monster pr, good job soldier!

frontend/src/views/authentication/LoginView.vue Outdated Show resolved Hide resolved
frontend/src/views/courses/roles/StudentCourseView.vue Outdated Show resolved Hide resolved
@EwoutV EwoutV changed the title feat: tree view for project submission structure feat: tree view for project submission structure, cleanups May 21, 2024
@EwoutV EwoutV requested a review from Topvennie May 21, 2024 19:48
@francisvaut francisvaut merged commit 6ecb8c4 into development May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeLany123 DeLany123 DeLany123 left review comments

@BramMeir BramMeir Awaiting requested review from BramMeir

@francisvaut francisvaut Awaiting requested review from francisvaut

@Topvennie Topvennie Awaiting requested review from Topvennie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create a tree view for structure checks
4 participants
@EwoutV @DeLany123 @Topvennie @francisvaut