Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission view #333

Merged
merged 25 commits into from
Apr 18, 2024
Merged

Submission view #333

merged 25 commits into from
Apr 18, 2024

Conversation

DeLany123
Copy link
Contributor

Adds

  • A way to upload a submission
  • A list of all the uploaded submissions

DeLany123 and others added 22 commits April 17, 2024 10:56
@DeLany123
feat: allsubmissions view
d857e84
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
0d8c2bf 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
@Topvennie @DeLany123
Run submission checks (#268)
9de7d43 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
@EwoutV @DeLany123
chore: improved layout
5ab9972
@DeLany123
feat: allsubmissions view 2
07fc582
@Topvennie @DeLany123
Run submission checks (#268)
28f878e 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
@EwoutV @DeLany123
chore: improved layout
04daa16
@DeLany123
Frontend rebased submission view
de3c2c2
@DeLany123
chore: commit before merge
f05e996
@DeLany123
chore: commit before rebasing
2990c65
@DeLany123
fix: Frontend works on new submissions
1a70f5e
@EwoutV @DeLany123
Better academic year selector, filtering and sorting (#292)
cb69b28 
* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination
@Topvennie @DeLany123
Run submission checks (#268)
d20fd89 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
@EwoutV @DeLany123
chore: improved layout
01f5961
@DeLany123
Frontend rebased submission view
5a2f5f2
@DeLany123
chore: commit before merge
8c7e244
@DeLany123
chore: finish logic submissionView.vue
c578ee8
@DeLany123
chore: bugfixes and layout
23bae64
@DeLany123
Merge branch 'refs/heads/development' into submission_view
66cca2a 
# Conflicts:
#	backend/setup.sh
#	frontend/src/assets/lang/nl.json
#	frontend/src/router/router.ts
@DeLany123
chore: Finished submissionView
356e3aa
@DeLany123
chore: lint fixes for #333
54e0700
@DeLany123
chore: Removed useless checks #333
0f86c93
@DeLany123 DeLany123 requested review from EwoutV and francisvaut and removed request for EwoutV April 18, 2024 14:44
EwoutV
EwoutV requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@EwoutV EwoutV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grape 👍

backend/api/serializers/submission_serializer.py Outdated Show resolved Hide resolved
backend/api/serializers/submission_serializer.py Outdated Show resolved Hide resolved
backend/setup.sh Outdated Show resolved Hide resolved
frontend/src/assets/scss/theme/base/components/overlay/_tooltip.scss Show resolved Hide resolved
frontend/src/composables/services/helpers.ts Outdated Show resolved Hide resolved
frontend/src/views/submissions/submissionView.vue Outdated Show resolved Hide resolved
@EwoutV EwoutV merged commit 56c21f7 into development Apr 18, 2024
3 checks passed
@EwoutV EwoutV deleted the submission_view branch April 18, 2024 16:28
@DeLany123 DeLany123 mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutV EwoutV EwoutV approved these changes

@francisvaut francisvaut Awaiting requested review from francisvaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeLany123 @EwoutV @Topvennie