fix: tests

SELab-2 · Apr 16, 2024 · 86bb212 · 86bb212
1 parent 927bcb0
commit 86bb212
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 30 deletions.
diff --git a/backend/api/tests/test_group.py b/backend/api/tests/test_group.py
@@ -80,15 +80,11 @@ def test_group_project(self):
         # Parse the JSON content from the response
         content_json = json.loads(response.content.decode("utf-8"))
 
-        expected_course_url = settings.TESTING_BASE_LINK + reverse(
-            "course-detail", args=[str(course.id)]
-        )
-
         self.assertEqual(content_json["name"], project.name)
         self.assertEqual(content_json["description"], project.description)
         self.assertEqual(content_json["visible"], project.visible)
         self.assertEqual(content_json["archived"], project.archived)
-        self.assertEqual(content_json["course"], expected_course_url)
+        self.assertEqual(content_json["course"]["id"], course.id)
 
     def test_group_students(self):
         """Able to retrieve students details of a group."""

diff --git a/backend/api/tests/test_project.py b/backend/api/tests/test_project.py
@@ -279,15 +279,11 @@ def test_project_exists(self):
 
         retrieved_project = content_json
 
-        expected_course_url = settings.TESTING_BASE_LINK + reverse(
-            "course-detail", args=[str(course.id)]
-        )
-
         self.assertEqual(retrieved_project["name"], project.name)
         self.assertEqual(retrieved_project["description"], project.description)
         self.assertEqual(retrieved_project["visible"], project.visible)
         self.assertEqual(retrieved_project["archived"], project.archived)
-        self.assertEqual(retrieved_project["course"], expected_course_url)
+        self.assertEqual(content_json["course"]["id"], course.id)
 
     def test_project_course(self):
         """
@@ -319,21 +315,9 @@ def test_project_course(self):
         self.assertEqual(retrieved_project["description"], project.description)
         self.assertEqual(retrieved_project["visible"], project.visible)
         self.assertEqual(retrieved_project["archived"], project.archived)
-
-        response = self.client.get(retrieved_project["course"], follow=True)
-
-        # Check if the response was successful
-        self.assertEqual(response.status_code, 200)
-
-        # Assert that the response is JSON
-        self.assertEqual(response.accepted_media_type, "application/json")
-
-        # Parse the JSON content from the response
-        content_json = json.loads(response.content.decode("utf-8"))
-
-        self.assertEqual(content_json["name"], course.name)
-        self.assertEqual(content_json["academic_startyear"], course.academic_startyear)
-        self.assertEqual(content_json["description"], course.description)
+        self.assertEqual(content_json["course"]["name"], course.name)
+        self.assertEqual(content_json["course"]["academic_startyear"], course.academic_startyear)
+        self.assertEqual(content_json["course"]["description"], course.description)
 
     def test_project_structure_checks(self):
         """
@@ -371,15 +355,11 @@ def test_project_structure_checks(self):
 
         retrieved_project = content_json
 
-        expected_course_url = settings.TESTING_BASE_LINK + reverse(
-            "course-detail", args=[str(course.id)]
-        )
-
         self.assertEqual(retrieved_project["name"], project.name)
         self.assertEqual(retrieved_project["description"], project.description)
         self.assertEqual(retrieved_project["visible"], project.visible)
         self.assertEqual(retrieved_project["archived"], project.archived)
-        self.assertEqual(retrieved_project["course"], expected_course_url)
+        self.assertEqual(content_json["course"]["id"], course.id)
 
         response = self.client.get(retrieved_project["structure_checks"], follow=True)