chore: submission status better than ever

SELab-2 · May 23, 2024 · 38d9aff · 38d9aff
1 parent d6eb2d8
commit 38d9aff
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/frontend/src/assets/lang/app/en.json b/frontend/src/assets/lang/app/en.json
@@ -195,12 +195,13 @@
         "card": {
             "open": "Details",
             "newProject": "New project",
-            "noSubmissions": "This project does not have any submissions",
+            "noSubmissions": "This project does not have any submissions \uD83D\uDE2D",
             "submissions": "Submission | Submissions",
             "groups": "Group | Groups",
             "structureTestsSucceed": "Succeeded structure tests",
             "extraTestsSucceed": "Succeeded extra tests",
             "testsFail": "Failed tests",
+            "successfulSubmission": "Successful submissions",
             "submit": "Submit"
         },
         "list": {

diff --git a/frontend/src/assets/lang/app/nl.json b/frontend/src/assets/lang/app/nl.json
@@ -202,6 +202,7 @@
             "structureTestsSucceed": "Geslaagde structuur testen",
             "extraTestsSucceed": "Geslaagde extra testen",
             "testsFail": "Gefaalde testen",
+            "successfulSubmission": "Geslaagde indieningen",
             "submit": "Indienen"
         },
         "list": {

diff --git a/frontend/src/components/submissions/ProjectMeter.vue b/frontend/src/components/submissions/ProjectMeter.vue
@@ -53,9 +53,10 @@ const meterItems = computed(() => {
             return [submissionsFailedItem, structureChecksPassedItem, extraChecksPassedItem]
         }
         structureChecksPassedItem.color = green
+        structureChecksPassedItem.icon = 'pi pi-check'
         return [submissionsFailedItem, structureChecksPassedItem]
     }
-    return [{ value: (groupsSubmitted / groups) * 100, color: green, label: t('components.card.testsFail'), icon: 'pi pi-times' }]
+    return [{ value: (groupsSubmitted / groups) * 100, color: green, label: t('components.card.successfulSubmission'), icon: 'pi pi-check' }]
 });
 </script>