Skip to content

Commit

Permalink
Merge pull request #199 from SELab-2/info_page_testen
Browse files Browse the repository at this point in the history
aboutpage layout + testen
  • Loading branch information
miboelae authored May 17, 2024
2 parents 720aa78 + c4f0e3e commit 2a737f7
Show file tree
Hide file tree
Showing 4 changed files with 65 additions and 13 deletions.
6 changes: 6 additions & 0 deletions frontend/src/i18n/locales/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,10 @@ export default {
all_students: "All students",
all_students_course: "All students in course:",
},
about: {
about: "About this project",
p_1: "This project was made as part of the course",
p_2: "The source code is publicly available at",
developers: "Our developers",
},
};
6 changes: 6 additions & 0 deletions frontend/src/i18n/locales/nl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,10 @@ export default {
all_students: "Alle studenten",
all_students_course: "Alle studenten in vak:",
},
about: {
about: "Over dit project",
p_1: "Dit project is gemaakt in het kader van het vak",
p_2: "De broncode is publiek beschikbaar op",
developers: "Onze developers",
},
};
51 changes: 38 additions & 13 deletions frontend/src/views/AboutView.vue
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
<template>
<div>
<h1>Over dit project</h1>
<p>
Dit project is gemaakt in het kader van het vak
<a href="https://studiekiezer.ugent.be/2023/studiefiche/nl/C003784">
Software Engineering Lab 2 </a
>. De broncode is publiek beschikbaar op
<a href="https://github.com/SELab-2/UGent-5"> GitHub </a>.
</p>
<h2>Onze Developers:</h2>
<div class="info">
<div class="about">
<h1>{{ $t("about.about") }}</h1>
<p>
{{ $t("about.p_1") }}
<a href="https://studiekiezer.ugent.be/2023/studiefiche/nl/C003784" class="link">
Software Engineering Lab 2 </a
>. {{ $t("about.p_2") }}
<a href="https://github.com/SELab-2/UGent-5" class="link"> GitHub </a>.
</p>
</div>
<h2>{{ $t("about.developers") }}:</h2>
<v-list lines="one">
<v-list-item v-for="developer in developers" :key="developer.name">
<v-list-item v-for="developer in developers" :key="developer.name" class="developers">
<template v-slot:title>
<v-btn :href="developer.githubUrl">{{ developer.name }}</v-btn>
<v-btn :href="developer.githubUrl" variant="flat">{{ developer.name }}</v-btn>
</template>
<template v-slot:subtitle>
{{ developer.role }}
Expand All @@ -30,7 +32,7 @@ interface Developer {
}
const developers: Developer[] = [
{
role: "Projectleider",
role: "Project Lead",
name: "Marieke Sinnaeve",
githubUrl: "https://github.com/masinnae",
},
Expand Down Expand Up @@ -66,3 +68,26 @@ const developers: Developer[] = [
},
];
</script>
<style scoped>
.info {
padding: 30px;
}
.link {
color: rgb(var(--v-theme-text));
}
.about {
margin-bottom: 25px;
}
.v-btn {
background-color: rgb(var(--v-theme-secondary));
}
.developers {
display: flex;
align-items: center;
margin-bottom: 15px;
}
</style>
15 changes: 15 additions & 0 deletions frontend/tests/views/AboutView.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { mount } from "@vue/test-utils";
import {expect, describe, it} from "vitest";
import AboutView from "../../src/views/AboutView.vue"


describe("About view", () => {
const wrapper = mount(AboutView, {});
it("renders title", () => {
expect(wrapper.text()).toContain("Over dit project")
});
it("render developers", () => {
const items = wrapper.findAllComponents(".developers")
expect(items.length).toBe(7)
});
});

0 comments on commit 2a737f7

Please sign in to comment.