Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Project detail page (add students) #461

Merged
merged 63 commits into from
May 21, 2022

Conversation

Tiebe-Vercoutter
Copy link
Contributor

Currently looks like this
afbeelding

afbeelding

Supports dnd: drag students to skills to add them

@stijndcl
Copy link
Contributor

Doesn't this branch from #395? Might want to change the base of the PR if so.

Copy link
Contributor

@stijndcl stijndcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InfoUrl is nullable. If this is used anywhere else in the code (I don't think it is), make sure to add a null check there as well.

@Tiebe-Vercoutter Tiebe-Vercoutter requested a review from stijndcl May 21, 2022 07:38
@Tiebe-Vercoutter
Copy link
Contributor Author

Doesn't this branch from #395? Might want to change the base of the PR if so.

I think so yes. So first merge this one into #395 ?

@Tiebe-Vercoutter Tiebe-Vercoutter changed the base branch from develop to create_project_skills May 21, 2022 07:40
@stijndcl
Copy link
Contributor

Doesn't this branch from #395? Might want to change the base of the PR if so.

I think so yes. So first merge this one into #395 ?

Up to you, I just didn't want anyone accidentally merging this one first. It's your choice which one gets merged.

@Tiebe-Vercoutter
Copy link
Contributor Author

Up to you, I just didn't want anyone accidentally merging this one first. It's your choice which one gets merged.

Yes okay this one can go into #395 and that one into develop. Solved the merge conflicts

@Tiebe-Vercoutter Tiebe-Vercoutter merged commit 45547e4 into create_project_skills May 21, 2022
@Tiebe-Vercoutter Tiebe-Vercoutter deleted the project_detail_page branch May 21, 2022 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frontend Issue related to the frontend
Projects
None yet
3 participants