This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 20, 2022
stijndcl
suggested changes
May 20, 2022
frontend/src/components/ProjectDetailComponents/ProjectCoaches/ProjectCoaches.tsx
Outdated
Show resolved
Hide resolved
Doesn't this branch from #395? Might want to change the base of the PR if so. |
stijndcl
suggested changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InfoUrl is nullable. If this is used anywhere else in the code (I don't think it is), make sure to add a null check there as well.
frontend/src/views/projectViews/ProjectDetailPage/ProjectDetailPage.tsx
Outdated
Show resolved
Hide resolved
Yes okay this one can go into #395 and that one into develop. Solved the merge conflicts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently looks like this
Supports dnd: drag students to skills to add them