Portfolio summary move to backend #4885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
added
the
Enhancement
perryr16
commented
Nov 22, 2024
| @@ -509,39 +509,44 @@ def build_view_filters_and_sorts( | |||
| return new_filters, annotations, order_by | |||
|
|
|||
|
|
|||
| def build_related_model_filters_and_sorts(filters: QueryDict, columns: list[dict]) -> tuple[Q, AnnotationDict, list[str]]: | |||
There was a problem hiding this comment.
This function was the source of the sorting bugs. Ordering by a related field in a 1-to-many relationship creates a SQL join, which duplicates rows when a property is part of multiple goals or goal_notes.
The new function works by querying and sorting the related models (goal_note & historical_note) independently, then mapping them back to property views. This avoids sorting-related issues at the parent level, simplifies the query, and resolves the duplication bug.
move functionality to backend dev - meeds pagination dev - meeds pagination added pagination labels functional naming logging
perryr16
force-pushed
the
portfolio-summary-move-to-backend
branch
from
7c04a45
to
758ca3d
Compare
perryr16
commented
Nov 22, 2024
| @@ -85,14 +85,41 @@ angular.module('SEED.controller.portfolio_summary', []) | |||
| // Can only sort based on baseline or current, not both. In the event of a conflict, use the more recent. | |||
| let baseline_first = false; | |||
|
|
|||
| const sort_goals = (goals) => goals.sort((a, b) => (a.name.toLowerCase() < b.name.toLowerCase() ? -1 : 1)); | |||
| const load_data = (page) => { | |||
There was a problem hiding this comment.
New load_data function fetches goal data in a single request.
perryr16
commented
Nov 22, 2024
| @@ -37,8 +37,6 @@ def get_filtered_results(request: Request, inventory_type: Literal["property", " | |||
| # check if there is a query parameter for the profile_id. If so, then use that one | |||
| profile_id = request.query_params.get("profile_id", profile_id) | |||
| shown_column_ids = request.query_params.get("shown_column_ids") | |||
| goal_id = request.data.get("goal_id") | |||
There was a problem hiding this comment.
portfolio summary no longer uses get_filtered_results. Removed goal logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
ICF reported sorting issues on the goal_note columns, leading to duplicate and unsorted results.
What's this PR do?
How should this be manually tested?
What are the relevant tickets?
#4886
Screenshots (if appropriate)