-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major dependency update #4806
Open
axelstudios
wants to merge
7
commits into
develop
Choose a base branch
from
task/dependency-update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Major dependency update #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
added
DO NOT MERGE
Maintenance
Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
labels
Sep 19, 2024
axelstudios
force-pushed
the
task/dependency-update
branch
7 times, most recently
from
September 20, 2024 18:37
f2a92e2
to
4b1a23b
Compare
…nx spelling issues, fixed sphinx-build on Windows, removed unused code
axelstudios
force-pushed
the
task/dependency-update
branch
from
September 20, 2024 22:25
efad6ca
to
954b14a
Compare
axelstudios
force-pushed
the
task/dependency-update
branch
from
September 23, 2024 19:08
47b4ec1
to
855c2f0
Compare
haneslinger
reviewed
Oct 1, 2024
@@ -13,6 +13,9 @@ | |||
|
|||
|
|||
class SensorViewSet(generics.GenericAPIView, viewsets.ViewSet, OrgMixin, ProfileIdMixin): | |||
# For the Swagger page, GenericAPIView asserts a value exists for `queryset` | |||
queryset = Sensor.objects.none() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why none
and not all
? I see mostly all
s in the existing codebase.
haneslinger
reviewed
Oct 1, 2024
@@ -1076,7 +1076,7 @@ def test_get_location(self): | |||
location, status = _get_location(self.property_view) | |||
self.assertEqual(status, "success") | |||
self.assertTrue(location is not None) | |||
self.assertEqual(location, "730 Garcia Street, Boring, Oregon, 97080") | |||
self.assertEqual(location, "1070 Hunt Street, Boring, Oregon, 97015") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Maintenance
Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
manage.py flush_db
command that wipes all database contents (and restarts table sequences) except for static tables (EEEJ and Uniformat)django-autoslug
dependencyNullBooleanField
<class 'seed.views.v3.sensors.SensorViewSet'> is not compatible with schema generation
<class 'seed.views.v3.tax_lot_properties.TaxLotPropertyViewSet'> is not compatible with schema generation
How should this be manually tested?
Monkey test, tests should pass