Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #84 | Implement CulturaX Dataloader #98

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

akhdanfadh
Copy link
Collaborator

Closes #84

I implemented one config per language/subset. Thus, configs will look like this: culturax_id_source, culturax_jv_seacrowd_ssp, etc. When testing, pass culturax_<subset> to the --subset_id parameter.

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @akhdanfadh ! 😄

I loaded each subset and had no issues with the data loader. Note for other reviewers that downloading the dataset might take long because each subset is more than a gig in size.

Just a few small comments and suggestions on formatting, but functionally, the data loader works.

seacrowd/sea_datasets/culturax/culturax.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/culturax/culturax.py Show resolved Hide resolved
seacrowd/sea_datasets/culturax/culturax.py Show resolved Hide resolved
seacrowd/sea_datasets/culturax/culturax.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/culturax/culturax.py Outdated Show resolved Hide resolved
- remove parquet article reference
- newline list comprehension
Copy link
Collaborator

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome work @akhdanfadh :) Let's just wait for the other reviewer's comments :)

@akhdanfadh
Copy link
Collaborator Author

akhdanfadh commented Nov 25, 2023

Done, should be ready to merge @SamuelCahyawijaya

Copy link
Collaborator

@SamuelCahyawijaya SamuelCahyawijaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamuelCahyawijaya SamuelCahyawijaya merged commit 4f68406 into SEACrowd:master Nov 27, 2023
1 check passed
@akhdanfadh akhdanfadh deleted the culturax branch November 27, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for CulturaX
3 participants