Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #612 | Add Dataloader AC-IQuAD #641

Merged
merged 11 commits into from
May 26, 2024

Conversation

muhammadravi251001
Copy link
Collaborator

@muhammadravi251001 muhammadravi251001 commented Apr 12, 2024

Title: Add Dataloader AC-IQuAD

First line PR Message: Closes #612

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@sabilmakbar sabilmakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick comment: I saw some inconsistencies when addressing single/simple subset names. Would you mind amending this first, @muhammadravi251001? Thanks!

@sabilmakbar
Copy link
Collaborator

2 more comments:

  1. Did you happen to not implementing the meta field for SEACrowd QA? Prob you might want to pull the latest QA schema first to fix it
  2. I saw in complex subset data, it has tipe key (prob type key in Indonesian), which has 4 distinct values for train (image 1) and 5 for test (image 2)
image image

Would you like to add it to the meta field as well for SEACrowd and introduce it as a new feature for the complex source schema?

@muhammadravi251001
Copy link
Collaborator Author

A quick comment: I saw some inconsistencies when addressing single/simple subset names. Would you mind amending this first, @muhammadravi251001? Thanks!

This is done by changing the single subset name to simple. From the paper & dataset itself, the author uses single and simple interchangeably -> single for the dataset name and simple for the explanation on the paper. Done on ef563f6 commit.

  1. Did you happen to not implementing the meta field for SEACrowd QA? Prob you might want to pull the latest QA schema first to fix it

I've already added the meta field on the 735cd2e commit.

  1. I saw in complex subset data, it has tipe key (prob type key in Indonesian), which has 4 distinct values for train (image 1) and 5 for test (image 2)

image image
Would you like to add it to the meta field as well for SEACrowd and introduce it as a new feature for the complex source schema?

Alright, done in f2aec29 commit.

Thanks for the careful review, Sir!

Copy link
Collaborator

@sabilmakbar sabilmakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@muhammadravi251001
Copy link
Collaborator Author

lgtm

Thanks for the approval, Sir!

Copy link
Collaborator

@dehanalkautsar dehanalkautsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! No comment from me👍 lgtm

@muhammadravi251001
Copy link
Collaborator Author

Hi! No comment from me👍 lgtm

Thanks for the approval, Sir!

@muhammadravi251001
Copy link
Collaborator Author

Since both reviewers approved, I will continue to squash & merge this PR. Thanks for the review!

@muhammadravi251001 muhammadravi251001 merged commit 0681eb6 into SEACrowd:master May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for AC-IQuAD
3 participants