-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #225 | Add Dataloader ALICE-THI #597
Conversation
I ran into this issue when I run
|
Will review this after you address @yongzx 's comments! Got a bit busy this week 😅 |
I don't know why the comment resulted in an error on your end, but not on mine. I've uncommented the line there. Also, ran the makefile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the source subset_ids and it passed! lgtm
It runs for me now! LGTM |
Closes #225
I implemented one config per language/subset. Thus, configs will look like this:
alice_thi_THI-C68_source
,alice_thi_THI-D10_seacrowd_imtext
, etc. When testing, passalice_thi_<subset>
to the--subset_id
parameter.Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
.