-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relates #31 | Add SEACrowd Speech Classification #55
Relates #31 | Add SEACrowd Speech Classification #55
Conversation
Since we have |
Apologies for mixing up things. That schema was supposed for Multiclass Classification, not Multilabel, will fix that soon. But I do agree that we shd separate it as 2. Would that be okay if we create another one for Multilabel regardless of schema adoption status (no one is using it rn)? |
53e22e2
to
cab228b
Compare
Hi, the codes have been updated & ready to be reviewed, implementing changes based on suggestion from Holy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabilmakbar Thanks for the discussion! Let's change the schema names to SPEECH
and SPEECH_MULTI
so they're consistent with TEXT
and TEXT_MULTI
?
Apologies Holy, overlooked that one. Please review it again and see whether all of the checks have been completed. Thanks! |
c2ba7f9
to
4805995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @sabilmakbar! Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It's related to Issue #31 in Fleurs Submission, where the schema of Speech Classification isn't available on SEACrowd Schema and Configs. This PR is created to add a new schema of Speech Classification.
cc @holylovenia @SamuelCahyawijaya