Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relates #31 | Add SEACrowd Speech Classification #55

Conversation

sabilmakbar
Copy link
Collaborator

It's related to Issue #31 in Fleurs Submission, where the schema of Speech Classification isn't available on SEACrowd Schema and Configs. This PR is created to add a new schema of Speech Classification.

cc @holylovenia @SamuelCahyawijaya

@holylovenia
Copy link
Contributor

Since we have text and text_multilabel schemas, isn't it better to be consistent and split the binary and the multilabel for speech classification into 2 separate schemas? What do you think? @sabilmakbar @SamuelCahyawijaya @fajri91

@sabilmakbar
Copy link
Collaborator Author

Apologies for mixing up things. That schema was supposed for Multiclass Classification, not Multilabel, will fix that soon. But I do agree that we shd separate it as 2. Would that be okay if we create another one for Multilabel regardless of schema adoption status (no one is using it rn)?

@sabilmakbar sabilmakbar force-pushed the sabil/add_speech_classification_schema branch from 53e22e2 to cab228b Compare November 15, 2023 11:24
@sabilmakbar
Copy link
Collaborator Author

Hi, the codes have been updated & ready to be reviewed, implementing changes based on suggestion from Holy.

Copy link
Contributor

@holylovenia holylovenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabilmakbar Thanks for the discussion! Let's change the schema names to SPEECH and SPEECH_MULTI so they're consistent with TEXT and TEXT_MULTI?

@sabilmakbar
Copy link
Collaborator Author

Apologies Holy, overlooked that one. Please review it again and see whether all of the checks have been completed. Thanks!

@sabilmakbar sabilmakbar force-pushed the sabil/add_speech_classification_schema branch from c2ba7f9 to 4805995 Compare November 16, 2023 09:48
Copy link
Contributor

@holylovenia holylovenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @sabilmakbar! Looks good to me.

Copy link
Collaborator

@SamuelCahyawijaya SamuelCahyawijaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamuelCahyawijaya SamuelCahyawijaya merged commit 96b3801 into SEACrowd:master Nov 16, 2023
1 check passed
@sabilmakbar sabilmakbar deleted the sabil/add_speech_classification_schema branch November 16, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants