-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #576 | Add Dataloader Vimqa
#678
Conversation
Hi @chenxwh, is it possible to upload the dataset via Google Drive? Want to review this ASAP since I'll be out next week, thanks! |
Hi! Not sure what's the best way, the authors required signing some form and they will give you access to their Google drive. I'm not sure if I can upload it publicly. |
Got it, let me see if I can get the dataset before the end of the week. Otherwise will let Holy reassign this to someone else |
I am waiting for the dataset. I sent request one week ago but didn`t get any response |
Hi @elyanah-aco and @MJonibek, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then. Since @chenxwh provided the unit test result, could you please do the review based on the implementation code? 🤔 Also feel free to ask @chenxwh to generate any outputs that would help your review process for this local dataloader. |
Thanks @holylovenia that sounds good, yes I am happy to address any concerns @MJonibek may have :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the meta & code flow are correct (provided unit test), LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the updated code (referring to the earlier comments) and given the data loader unit test prior to changes (which supposedly won't change the test output), I have no other concerns about this.
Closes #576
Checkbox
seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py
(please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its__init__.py
within{my_dataset}
folder._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_LOCAL
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
orpython -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}
.Here is the output of the unit-tests: