Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #223 | Add/Update Dataloader VinText #649

Merged
merged 15 commits into from
May 31, 2024

Conversation

patrickamadeus
Copy link
Collaborator

Closes #223

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
  • [.] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Tests

image

Copy link
Collaborator

@akhdanfadh akhdanfadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataloader tested and worked at first, but please address my discussions below.

requirements.txt Outdated Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Outdated Show resolved Hide resolved
seacrowd/utils/schemas/image_text.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Outdated Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Show resolved Hide resolved
seacrowd/sea_datasets/vintext/vintext.py Outdated Show resolved Hide resolved
@holylovenia holylovenia requested review from ljvmiranda921 and removed request for fhudi and ljvmiranda921 May 21, 2024 09:06
@patrickamadeus
Copy link
Collaborator Author

Hi @akhdanfadh! I've addressed the suggestions! For now I will change the description and proceed with the original version of dataset.

Thank you for the meaningful reviews!

@sabilmakbar
Copy link
Collaborator

Hi, @akhdanfadh @fhudi. Would you like to review the latest code changes? Thanks!

@holylovenia
Copy link
Contributor

Hi @fhudi @akhdanfadh, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.

cc: @patrickamadeus

Copy link
Collaborator

@fhudi fhudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Passed the tests.
Thanks for being cooperative!

@fhudi
Copy link
Collaborator

fhudi commented May 31, 2024

Hi @akhdanfadh,
It seems all the previous concerns have been addressed.
Could you please re-review the latest code changes? thanks.
cc: @sabilmakbar

@akhdanfadh
Copy link
Collaborator

@fhudi The code tested and OK. My only comment is that the change in image_text.py schema is insignificant. Could we remove that?

@fhudi
Copy link
Collaborator

fhudi commented May 31, 2024

@akhdanfadh sure, please do.
I am fine with either one.

@akhdanfadh
Copy link
Collaborator

Merging now. @patrickamadeus @fhudi

@akhdanfadh akhdanfadh merged commit 95efbb1 into SEACrowd:master May 31, 2024
1 check passed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding additional comment here.
Though, too bad that the new line at the EOF is gone 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for VinText
6 participants