-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #223 | Add/Update Dataloader VinText #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dataloader tested and worked at first, but please address my discussions below.
Co-authored-by: Akhdan Fadhilah <[email protected]>
Co-authored-by: Akhdan Fadhilah <[email protected]>
Co-authored-by: Akhdan Fadhilah <[email protected]>
Hi @akhdanfadh! I've addressed the suggestions! For now I will change the description and proceed with the original version of dataset. Thank you for the meaningful reviews! |
Hi, @akhdanfadh @fhudi. Would you like to review the latest code changes? Thanks! |
Hi @fhudi @akhdanfadh, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then. cc: @patrickamadeus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Passed the tests.
Thanks for being cooperative!
Hi @akhdanfadh, |
@fhudi The code tested and OK. My only comment is that the change in |
@akhdanfadh sure, please do. |
Merging now. @patrickamadeus @fhudi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding additional comment here.
Though, too bad that the new line at the EOF is gone 🥲
Closes #223
Checkbox
seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py
(please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its__init__.py
within{my_dataset}
folder._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_LOCAL
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
orpython -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}
.Tests