-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #51 | Add id_sentiment_analysis dataloader #455
Conversation
I might need help on the citation |
Hi @Enliven26, apparently, when I checked the website, it didn't point to any technical paper informing how this dataset was constructed from its Homepage and Paper URL. But when I checked on the description, it has a publication of sentiment-analysis experimentation using this dataset. A qn for @holylovenia and @SamuelCahyawijaya: should we cite that experimentation paper even though they only use this dataset, or should we cite the announcement article instead? |
Is it by the same author/dataset owner? If yes, then it's okay to cite it. |
Sadly, no. None of the names listed on the dataset announcement blog appeared as an author in that experiment paper. |
Then maybe we can add a simple citation to the data repo? |
May I know what the citation would be? |
Like this, @Enliven26?
|
seacrowd/sea_datasets/id_sentiment_analysis/id_sentiment_analysis.py
Outdated
Show resolved
Hide resolved
seacrowd/sea_datasets/id_sentiment_analysis/id_sentiment_analysis.py
Outdated
Show resolved
Hide resolved
seacrowd/sea_datasets/id_sentiment_analysis/id_sentiment_analysis.py
Outdated
Show resolved
Hide resolved
Hi @yongzx , please tell me if there is anything else I can change, thanks |
seacrowd/sea_datasets/id_sentiment_analysis/id_sentiment_analysis.py
Outdated
Show resolved
Hide resolved
seacrowd/sea_datasets/id_sentiment_analysis/id_sentiment_analysis.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Salsabil Maulana Akbar <[email protected]>
…seacrowd-datahub into id_sentiment_analysis
Hi @sabilmakbar , please inform me if there is anything else I can change. Thanks! |
Done @yongzx ! Please tell me anything else I can change, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @Enliven26!
@yongzx, a friendly reminder to review. 😁 |
LGTM! |
Closes #51
Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
.