Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #51 | Add id_sentiment_analysis dataloader #455

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

Enliven26
Copy link
Contributor

Closes #51

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@Enliven26
Copy link
Contributor Author

I might need help on the citation

@sabilmakbar
Copy link
Collaborator

Hi @Enliven26, apparently, when I checked the website, it didn't point to any technical paper informing how this dataset was constructed from its Homepage and Paper URL. But when I checked on the description, it has a publication of sentiment-analysis experimentation using this dataset.

A qn for @holylovenia and @SamuelCahyawijaya: should we cite that experimentation paper even though they only use this dataset, or should we cite the announcement article instead?

@sabilmakbar sabilmakbar self-assigned this Feb 26, 2024
@holylovenia holylovenia changed the title feat: id_sentiment_analysis dataloader Closes #51 | Add id_sentiment_analysis dataloader Feb 28, 2024
@holylovenia
Copy link
Contributor

holylovenia commented Feb 28, 2024

Hi @Enliven26, apparently, when I checked the website, it didn't point to any technical paper informing how this dataset was constructed from its Homepage and Paper URL. But when I checked on the description, it has a publication of sentiment-analysis experimentation using this dataset.

A qn for @holylovenia and @SamuelCahyawijaya: should we cite that experimentation paper even though they only use this dataset, or should we cite the announcement article instead?

Is it by the same author/dataset owner? If yes, then it's okay to cite it.

@sabilmakbar
Copy link
Collaborator

Is it by the same author/dataset owner? If yes, then it's okay to cite it.

Sadly, no. None of the names listed on the dataset announcement blog appeared as an author in that experiment paper.

@holylovenia
Copy link
Contributor

Is it by the same author/dataset owner? If yes, then it's okay to cite it.

Sadly, no. None of the names listed on the dataset announcement blog appeared as an author in that experiment paper.

Then maybe we can add a simple citation to the data repo?

@Enliven26
Copy link
Contributor Author

Is it by the same author/dataset owner? If yes, then it's okay to cite it.

Sadly, no. None of the names listed on the dataset announcement blog appeared as an author in that experiment paper.

Then maybe we can add a simple citation to the data repo?

May I know what the citation would be?

@holylovenia
Copy link
Contributor

Like this, @Enliven26?

@misc{ridife2019idsa,
  author = {Fe, Ridi},
  title = {Indonesia Sentiment Analysis Dataset},
  year = {2019},
  publisher = {GitHub},
  journal = {GitHub repository},
  howpublished = {\url{https://github.com/ridife/dataset-idsa}}
}

@Enliven26 Enliven26 requested a review from tellarin as a code owner March 4, 2024 08:40
@holylovenia holylovenia removed the request for review from tellarin March 5, 2024 10:30
@Enliven26
Copy link
Contributor Author

Hi @yongzx , please tell me if there is anything else I can change, thanks

@Enliven26
Copy link
Contributor Author

Hi @sabilmakbar , please inform me if there is anything else I can change. Thanks!

@Enliven26
Copy link
Contributor Author

Done @yongzx ! Please tell me anything else I can change, thanks

@holylovenia holylovenia added the top-priority Needs to get done ASAP for the experiments label Mar 12, 2024
Copy link
Collaborator

@sabilmakbar sabilmakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Enliven26!

@sabilmakbar sabilmakbar requested a review from yongzx March 15, 2024 12:39
@holylovenia
Copy link
Contributor

lgtm, thanks @Enliven26!

@yongzx, a friendly reminder to review. 😁

@yongzx
Copy link
Collaborator

yongzx commented Mar 26, 2024

LGTM!

@yongzx yongzx merged commit 9a25e4d into SEACrowd:master Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
top-priority Needs to get done ASAP for the experiments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for Indonesia Sentiment Analysis Dataset
4 participants