SA-14771 fix dshow get device list when only audio devices available #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c6f552b.
Needed to enable programmatic discovery of DirectShow devices Signed-off-by: Diederick Niehorster <[email protected]> Reviewed-by: Roger Pack <[email protected]> (cherry picked from commit ec579b4) Conflicts: libavdevice/dshow.c
lm3m
approved these changes
Mar 10, 2023
| int i; | ||
|
|
||
| r = CoGetMalloc(1, &co_malloc); | ||
| if (r != S_OK) | ||
| goto fail1; | ||
| goto fail; |
There was a problem hiding this comment.
if you want to, you could convert the goto fail in a variable and a break
| } | ||
|
|
||
| fail1: | ||
| fail: | ||
| if (device) { |
| if (!device_list) | ||
| return AVERROR(EINVAL); | ||
|
|
||
| CoInitialize(0); |
There was a problem hiding this comment.
expensive if we do this too often (maybe have one thread where we do com/dshow stuff?)
There was a problem hiding this comment.
yeh we can probably limit the amount of calls to this code when we create FFmpegDevice instances on our end - instead of calling QueryForDevices() we could refactor it out into a separate thing like we have on this branch https://github.com/SBGSports/SBGSource/blob/2b0efd1cf3c52149f279f017c23300418486e94a/RaceMedia/ffmpeg_device_list.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sbgsportssoftware.atlassian.net/browse/SA-14771