fix(platform): table filter enhancement #12771

khotcholava · 2024-11-25T13:50:12Z

feat(core):
closes #11783

Add support for formatting array values in table component
Fix format field name

Before

After

closes [#11783](#11783) - add support for formatting array values in table component

closes [#11783](#11783) ## Description Updated the filter parameter to use the column name for improved representation.

netlify · 2024-11-25T13:52:13Z

✅ Deploy Preview for fundamental-ngx ready!

Name	Link
🔨 Latest commit	`221e252`
🔍 Latest deploy log	https://app.netlify.com/sites/fundamental-ngx/deploys/676426d38bb4ec00088f7aa6
😎 Deploy Preview	https://deploy-preview-12771--fundamental-ngx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-11-25T13:54:52Z

Visit the preview URL for this PR (updated for commit 221e252):

https://fundamental-ngx-gh--pr12771-11783-table-filter-e-e58ep12c.web.app

_{(expires Sun, 22 Dec 2024 19:34:22 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff}

closes [#11783](#11783) ## Description fix table component host spec test

khotcholava · 2024-12-04T11:52:51Z

@mikerodonnell89 @dpavlenishvili Ping

InnaAtanasova · 2024-12-04T18:29:38Z

Please use proper naming for the PRs. If this gets merged without the proper title we would need to manually fix the release notes

InnaAtanasova · 2024-12-04T18:30:49Z

libs/platform/table-helpers/services/table.service.ts

@@ -468,6 +480,11 @@ export class TableService {
        this.buildSortRulesMap();
        this.buildFilterRulesMap();
    }
+
+    private getFieldName(field: string): string {


A private method should be prefixed by _ and should have typedocs annotations.

- Added '_', and annotation to private method

mikerodonnell89

Two things I noticed:

There's a space before the comma
no "Status Color" text, just "(critical)"

karolgromacki · 2024-12-09T09:18:46Z

Hi @khotcholava , I've noticed one problem - so far the info bar is displayed after changing the filter through UI or from code, but I have a case when I load the whole tableState from the session storage and it doesn't apply the filter info bar - it seems that the problem is related to
this._tableService.stateChange$.subscribe(({ type, state }) => { switch (type) {

because when we use this.table.setTableState(tableState), the state is changed, but the type is undefined and
this._setAppliedFilterNames(state.current); is not executed.

closes [#11783](#11783) Correct handling of filter inputs by using the columnName instead of columnKey to better represent user selections. Additionally, toolbar styling is modified to prevent unnecessary shrinking, thus enhancing the overall interface consistency.

closes [#11783](#11783) Fixed filter dialog filtering

closes [#11783](#11783) Removed space between filter param and coma

closes [#11783](#11783) Fixed formatting

khotcholava · 2024-12-17T16:28:45Z

@karolgromacki Please include the valid code example. It's easier for me to debug.

closes [#11783](#11783) Fixed formatting

droshev · 2024-12-18T15:18:49Z

@khotcholava fix the linting issues, make sure e2e/unit are not failing. Then we should review it.

closes [#11783](#11783) Removed space between filter param and coma

closes [#11783](#11783) Fixed formatting

[#12677](#12677) Fixed an issue where using `semanticHighlighting` and `group` properties simultaneously in `fdp-table` caused unexpected behavior. Updated logic to ensure compatibility and proper rendering when these features are used together. Co-authored-by: khotcholava <[email protected]>

)

… theme/language automatically, add readonly property to form generator (#12739) * fix(platform): update settings generator docs and component to update theme/language automatically, add readonly property to form generator * fix: do not use autocomplete="off" for all inputs * fix: simplify readonly function

BREAKING CHANGE: remove inline SVG support * fix(core, platform): fix illustrated message in table * fix(core): remove inline SVG support for illustrated messages

* fix(core): fix form field spacing * test(platform): migrate e2e to unit

…into 11783-table-filter-enhancement

khotcholava added 2 commits November 19, 2024 19:23

feat(core):

5967ae8

closes [#11783](#11783) - add support for formatting array values in table component

feat(core):

3f135e0

closes [#11783](#11783) ## Description Updated the filter parameter to use the column name for improved representation.

khotcholava self-assigned this Nov 25, 2024

khotcholava requested review from mikerodonnell89, droshev and InnaAtanasova November 25, 2024 13:50

khotcholava and others added 5 commits November 27, 2024 17:50

Merge branch 'main' into 11783-table-filter-enhancement

c11dc19

feat(platform): table filter enhancement

34e1581

closes [#11783](#11783) ## Description fix table component host spec test

feat(platform): table filter enhancement

5c3ed1f

closes [#11783](#11783) ## Description fix table component host spec test

feat(platform): table filter enhancement

c1c7ab0

closes [#11783](#11783) ## Description fix table component host spec test

feat(platform): table filter enhancement

20f6e29

closes [#11783](#11783) ## Description fix table component host spec test

khotcholava marked this pull request as ready for review December 1, 2024 15:40

droshev added this to the Sprint 141 - December 2024 milestone Dec 4, 2024

InnaAtanasova changed the title ~~11783 table filter enhancement~~ fix(platform): table filter enhancement Dec 4, 2024

InnaAtanasova reviewed Dec 4, 2024

View reviewed changes

feat(platform): table filter enhancement

a0d9d35

- Added '_', and annotation to private method

khotcholava requested a review from InnaAtanasova December 4, 2024 18:40

mikerodonnell89 requested changes Dec 5, 2024

View reviewed changes

khotcholava added 4 commits December 9, 2024 17:34

fix(table): table filter toolbar

117f058

closes [#11783](#11783) Fixed filter dialog filtering

fix(table): table filter toolbar

1db00cb

closes [#11783](#11783) Removed space between filter param and coma

fix(platform): table filter toolbar

4a08c25

closes [#11783](#11783) Fixed formatting

khotcholava requested a review from mikerodonnell89 December 17, 2024 16:28

fix(platform): table filter toolbar

eb5d57b

closes [#11783](#11783) Fixed formatting

Merge branch 'main' into 11783-table-filter-enhancement

14898cc

khotcholava and others added 22 commits December 19, 2024 17:58

fix(platform): table filter toolbar

14e05c4

closes [#11783](#11783) Removed space between filter param and coma

fix(platform): table filter toolbar

68df50b

closes [#11783](#11783) Fixed formatting

fix(platform): table filter toolbar

dc43d8b

closes [#11783](#11783) Fixed formatting

fix(platform): remove emtpy tab in dynamic page with tabs (#12786)

f6698e9

chore(release): publish 0.53.2-rc.14 [ci skip]

526bfb9

chore(release): publish 0.53.2-rc.15 [ci skip]

e98c01e

fix(docs): extra scrollbar track showing on docs page for chrome (#12794

0ebc249

)

chore(release): publish 0.53.2-rc.16 [ci skip]

8102ed2

fix(platform): update Load More label with Show More (#12806)

24ecf26

chore(release): publish 0.53.2-rc.17 [ci skip]

8522e37

chore(release): publish 0.53.2-rc.18 [ci skip]

972b92a

chore(release): publish 0.53.2 [ci skip]

15b50be

fix(core, platform): fix illustrated message in table (#12689)

280d7a8

BREAKING CHANGE: remove inline SVG support * fix(core, platform): fix illustrated message in table * fix(core): remove inline SVG support for illustrated messages

chore(release): publish 0.54.0-rc.0 [ci skip]

fdfe4e1

fix(core): fix form field spacing (#12819)

89bf0ac

* fix(core): fix form field spacing * test(platform): migrate e2e to unit

chore(release): publish 0.54.0-rc.1 [ci skip]

2557145

chore: remove notworking workflow (#12830)

d6f76b6

chore(release): publish 0.54.0-rc.2 [ci skip]

5f1c23f

chore(release): publish 0.54.0 [ci skip]

c069e10

Merge remote-tracking branch 'origin/11783-table-filter-enhancement' …

221e252

…into 11783-table-filter-enhancement

khotcholava closed this Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(platform): table filter enhancement #12771

fix(platform): table filter enhancement #12771

khotcholava commented Nov 25, 2024

netlify bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

khotcholava commented Dec 4, 2024

InnaAtanasova commented Dec 4, 2024

InnaAtanasova Dec 4, 2024

mikerodonnell89 left a comment

karolgromacki commented Dec 9, 2024 •

edited

Loading

khotcholava commented Dec 17, 2024

droshev commented Dec 18, 2024

fix(platform): table filter enhancement #12771

fix(platform): table filter enhancement #12771

Conversation

khotcholava commented Nov 25, 2024

Before

After

netlify bot commented Nov 25, 2024 • edited Loading

✅ Deploy Preview for fundamental-ngx ready!

github-actions bot commented Nov 25, 2024 • edited Loading

khotcholava commented Dec 4, 2024

InnaAtanasova commented Dec 4, 2024

InnaAtanasova Dec 4, 2024

Choose a reason for hiding this comment

mikerodonnell89 left a comment

Choose a reason for hiding this comment

karolgromacki commented Dec 9, 2024 • edited Loading

khotcholava commented Dec 17, 2024

droshev commented Dec 18, 2024

netlify bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

karolgromacki commented Dec 9, 2024 •

edited

Loading