Improving Agent and Person Code Coverage. #82
Conversation
| @@ -54,14 +54,11 @@ public function asVersion($version) { | |||
| if (! empty($versioned_acct)) { | |||
| $result['account'] = $versioned_acct; | |||
| } | |||
| } | |||
| elseif (isset($this->mbox_sha1sum)) { | |||
| } else if (isset($this->mbox_sha1sum)) { | |||
There was a problem hiding this comment.
For some reason phpcc won't consider these lines covered when written like this:
elseif (condition) {
}
elseif (condition) {
}This might just be me but I don't think so.
|
Seems like it's failing due to an existing error. This should be fine to merge. |
|
I can't obviously see how the latest changes would cause the tests to fail, but odd that the current master is passing. I'd be tempted to do a fake PR of an additional code comment and see if that fails in the same way too. |
|
Yeah it is strange. Let me know how you get on. It may have just been that Scorm Cloud was having issues at the time. I'll reopen this to trigger the build again. |
|
Now that it's been a couple of days lets check it again. |
|
@garemoko Seems like an issue with Scorm Cloud. Is it normal to submit a ticket for this kind of thing? |
|
@WillSkates you could drop an email to [email protected] Have you tried running the tests against another LRS? |
|
@garemoko I haven't. I'll try it again later tonight. Did you have any success? |
|
Apologies as I still haven't had a chance to look at this. I'll reopen to see if the issue has fixed itself. |
|
Quick google around suggests that the issue is at the other end. Looks like a java exception that's being thrown somewhere. |
This is to avoid the namespacing changes that come in PHPUnit 6.
No description provided.