Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compatibility with xAPI version 1.0.3 #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added compatibility with xAPI version 1.0.3 #28

wants to merge 2 commits into from

Conversation

madmox
Copy link
Contributor

@madmox madmox commented Feb 21, 2017

  • Updated known & supported versions
  • Point latest version to 1.0.3
  • Assembly version bump

This was referenced Feb 21, 2017
Open
Open
@garemoko
Copy link

Just curious - this PR only addresses #27 and not #26, right?

@madmox
Copy link
Contributor Author

madmox commented Feb 21, 2017 •
edited
Loading

Yes, exactly. I don't think 1.0.3 added anything significant in the spec from 1.0.2 or even 1.0.0 to require other changes in the code base, does it? (the changelog is not very exhaustive)

(I removed the reference to this PR from #26 to avoid confusion)

@ghost
Copy link

ghost commented Dec 20, 2017

Tests are failing on Master because of 1.0.3.
Is the conflict on AssemblyInfo.cs the only reason this pull request has not been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madmox @garemoko