Making custom map names show up on the world map #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, giving buildings custom names doesn't actually make their name show up on the overworld map, and in some other instances like leaving the map. This makes it so that when you rename something the new name shows up all the time. e.g. naming a shop Snail-Mart and walking over it will show "You see Snail-Mart." instead of "You see Shop."
adata(ADATA_FESTIVAL, gdata(GDATA_AREA)) = 0
is commented out inmap_user.hsp
because that causes unwanted behavior when canceling from the rename screen, and has no purpose otherwise.ADATA_FESTIVAL
was already set to 9999 whenever the player gave a map a custom name, in this code that's being used to detect if a map was custom-named, basically.There's also a small fix(?) where the "You named it [name]" is put after the
screen_refreshFull
so the player actually sees it, and a botched copypasta probably from the creature renaming code was fixed to show the new map name.