Skip to content

Commit

Permalink
Disable Loader pri-1 tests that don't compile (dotnet#102709)
Browse files Browse the repository at this point in the history
These test various bad or crazy IL that we're never going to fix due to a test failure alone (would need a better business justification to spend time on).
  • Loading branch information
MichalStrehovsky authored and Ruihan-Yin committed May 30, 2024
1 parent e014c7e commit de2c1db
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@

<PropertyGroup>
<RunAnalyzers>true</RunAnalyzers>
<NativeAotIncompatible>true</NativeAotIncompatible>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<CLRTestPriority>1</CLRTestPriority>
<!-- 10000 generic parameters hits implementation limits in CodeView debug information -->
<NativeAotIncompatible>true</NativeAotIncompatible>
</PropertyGroup>
<ItemGroup>
<Compile Include="GenericParams10k.cs" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props, $(MSBuildThisFileDirectory)..))" />

<PropertyGroup>
<NativeAotIncompatible>true</NativeAotIncompatible>
</PropertyGroup>
</Project>
3 changes: 0 additions & 3 deletions src/tests/issues.targets
Original file line number Diff line number Diff line change
Expand Up @@ -973,9 +973,6 @@
<ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/explicitlayout/Regressions/ASURT/ASURT150271/test3/*">
<Issue>Won't fix https://github.com/dotnet/corert/issues/2396</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/generics/Instantiation/Negative/abstract01/*">
<Issue>https://github.com/dotnet/runtimelab/issues/155: Thorough checking of invalid inputs</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/MethodImpl/generics_override1/*">
<Issue>https://github.com/dotnet/runtimelab/issues/207</Issue>
</ExcludeList>
Expand Down

0 comments on commit de2c1db

Please sign in to comment.