Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual versions for parallel #332

Closed
wants to merge 2 commits into from
Closed

Conversation

27pchrisl
Copy link
Contributor

Hi @andrewdalpino,

To resolve #305 is it suitable to dual-require parallel versions 1.3 and 2.2, and let Composer choose the right one based on your PHP version?

@andrewdalpino
Copy link
Member

Hey thanks @27pchrisl this could very well be a solution but we may have to make some changes to the code itself. See the failed test here https://github.com/RubixML/ML/actions/runs/9035283567/job/24858504227?pr=332 and let me know what you think. Thanks again!

@27pchrisl
Copy link
Contributor Author

Hiya @andrewdalpino, I created an Amp2 class that the package user can use if they have the v2 of parallel. Essentially a clone of Amp but implementing the newer interface.

@27pchrisl
Copy link
Contributor Author

I could implement a common abstract class, but it would only really abstract away the constructor and the __toString method, so I have created them completely separately.

@andrewdalpino
Copy link
Member

Unfortuantely we don't have the resources to support this at this time. Will look to upgrading to Amp Parallel 2.2 in ML 3.0. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements not resolved to an installable set of packages
2 participants