-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move tools to a separate directory #316
base: 3.0
Are you sure you want to change the base?
Conversation
Is this solving a problem that we have currently? Or a potential one in the future? |
@andrewdalpino it solves the current problem: I can't use the latest I want to upgrade I'm just stuck in a dependency hell - I wanted to decouple all those tooling dependencies from the core codebase. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this doesn't effect the installability via composer require rubix/ml
then I think we're good to go
Hey @mcharytoniuk is this still needed? |
The goal is to avoid dependencies between tools.
For example the latest
phpstan
and the latestphpunit
depend on a different version of https://github.com/sebastianbergmann/diffAlso it won't cause as many potential dependency conflicts between RubixML and the end user projects.
I modified
composer.json
, so scripts should work exactly as before (for examplecomposer anayze
runsphpstan
).I made an exception for
phpunit
, sophpstan
can still analyze the test files.Next step would be to also add https://github.com/rectorphp/rector to the tools directory and update phpunit to v11 (tbd in a different PR)