Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ridge regressor: switch to numpower #315

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

mcharytoniuk
Copy link
Member

@mcharytoniuk mcharytoniuk commented Feb 7, 2024

Thoughts so far:

  1. it's easy to build and run NumPower
  2. when using GPU got some SIGSEGV when transposing a matrix, other operations seem to be fine
  3. even on CPU there is a performance gain
  4. to avoid switching between PHP context and internal Matrix representation in NumPower it might be necessary to implement some more matrix operations in NumPower?

@andrewdalpino andrewdalpino requested a review from a team February 8, 2024 23:30
@andrewdalpino
Copy link
Member

Very nice work! We're on the same page. For the changes we need to Num Power, let's temporarily fork it to test the POC and then submit any PRs to the main repo when it's all done.

I'll continue to try to hunt down Henrique lol :)

@mcharytoniuk mcharytoniuk marked this pull request as draft February 14, 2024 01:13
@mcharytoniuk mcharytoniuk changed the title [work in progress] Ridge regressor: switch to numpower Ridge regressor: switch to numpower Feb 14, 2024
@andrewdalpino andrewdalpino marked this pull request as ready for review March 5, 2024 03:06
@andrewdalpino andrewdalpino merged commit ca59648 into RubixML:3.0 Dec 26, 2024
1 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants