-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper interface #314
Wrapper interface #314
Conversation
Cool! Thanks @ElGigi, I think we had something like this before but I can't remember why we got rid of it! I'll give it a closer look when I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I left some comments ... I remember having an interface like this before, but I can't remember why we removed it exactly. My guess is that it didn't serve any internal use cases so we just dropped it.
I can think of a few external use cases for an interface like this. The one you mentioned is a good one. Do you have any in particular in your own projects?
P.S. To fix the coding style automatically you can run |
In our project, we abstract of the final model. To allow to define own model in sub-libraries. The final service don't known the model but only interface, so to define if we set a logger or if the model is trainable, we need to retrieve the base estimator. |
I do 👍 I didn't want to do that because it would modify too many files. Unrelated to my PR. |
Added a
Wrapper
interface to identify enclosing models.And thus allow for example to test if a included model implements a particular interface like
LoggerAwareInterface
.