-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOK-525: values-digits-display #470
Open
franciscotobar
wants to merge
3
commits into
develop
Choose a base branch
from
TOK-525/values-digits-display
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+586
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscotobar
changed the title
feat: format currency, symbol and metrics
TOK-525/values-digits-display
Dec 11, 2024
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
franciscotobar
force-pushed
the
TOK-525/values-digits-display
branch
3 times, most recently
from
December 11, 2024 04:56
95e337a
to
1be2da4
Compare
antomor
reviewed
Dec 11, 2024
src/app/collective-rewards/leaderboard/BuildersLeaderBoardTable.tsx
Outdated
Show resolved
Hide resolved
antomor
reviewed
Dec 11, 2024
src/app/collective-rewards/leaderboard/BuildersLeaderBoardTable.tsx
Outdated
Show resolved
Hide resolved
antomor
reviewed
Dec 11, 2024
src/app/collective-rewards/rewards/builders/hooks/useGetBuildersRewards.ts
Show resolved
Hide resolved
antomor
reviewed
Dec 11, 2024
antomor
reviewed
Dec 11, 2024
src/app/collective-rewards/rewards/hooks/useGetBackerRewardPercentage.ts
Outdated
Show resolved
Hide resolved
antomor
reviewed
Dec 11, 2024
src/app/collective-rewards/rewards/hooks/useGetBackersRewardPercentage.ts
Outdated
Show resolved
Hide resolved
antomor
reviewed
Dec 11, 2024
antomor
reviewed
Dec 11, 2024
franciscotobar
force-pushed
the
TOK-525/values-digits-display
branch
from
December 11, 2024 19:01
1be2da4
to
b5f2a72
Compare
franciscotobar
force-pushed
the
TOK-525/values-digits-display
branch
from
December 11, 2024 19:03
b5f2a72
to
059a68d
Compare
antomor
reviewed
Dec 12, 2024
antomor
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOK-525