Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting functionality and refactor table components #445

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

shenshin
Copy link
Contributor

@shenshin shenshin commented Dec 3, 2024

Introduce sorting capabilities and custom renderers to the table component. Refactor the proposals table for better separation of data and presentation, and enhance the overall structure with new components for proposal name and status. Clean up ESLint configurations and improve type definitions.

Copy link

github-actions bot commented Dec 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@tanstack/react-table 8.20.5 UnknownUnknown
npm/@tanstack/table-core 8.20.5 UnknownUnknown
npm/@tanstack/react-table ^8.20.5 UnknownUnknown

Scanned Files

  • package-lock.json
  • package.json

@shenshin
Copy link
Contributor Author

shenshin commented Dec 3, 2024

Screenshot 2024-12-03 at 05 42 46

Copy link
Contributor

@LordCheta LordCheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rodrigoncalves
Copy link
Contributor

@shenshin please fix lint errors.

@shenshin
Copy link
Contributor Author

shenshin commented Dec 4, 2024

Which errors? By the way , before starting working on this pr , I installed additional linting plugins. The app misses some very important linters such as eslint-plugin-react , react hooks and so on. But after finishing work I removed the modules because they should be better installed in a separate PR. So , I don't know what linting error you mean. Could you please give more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants