DAO-593 Added tutorial to get dApp running locally. #390
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
| ```javascript | ||
| this.app.use(cors({ | ||
| origin: (origin, callback) => { | ||
| if (true) { // <-- |
There was a problem hiding this comment.
Instead of changing the conditional, I suggest to add http://localhost:3000 to whitelist.
There was a problem hiding this comment.
I think it's a less invasive change and it makes cleanup and reversion easier later on. Just a suggestion.
There was a problem hiding this comment.
I am not quite following. The mere purpose of this change is to be able to run the frontend locally. You can run it locally at any port, it can be 3000, 3001, 8080, etc.... Adding it as localhost:3000 could be misleading, instead, by commenting out the conditional, we can ensure a seamless backend connection without running into CORS issues, which is a solid improvement.
Could you provide a bit more context about the cleanup and reversion? It would be helpful to understand the background for these changes.
This approach should make it much easier to connect the frontend to the backend during local development, and I'm happy to help refine it further if needed.
There was a problem hiding this comment.
I know those are temporary changes in order to run it locally. localhost:3000 was just an example, it could be any port, it's the same as you did when you set port 3001 for NEXT_PUBLIC_RIF_WALLET_SERVICES. But anyway, it just a matter of preference. I personally prefer adding the local frontend address into whitelist instead of changing any logic in the code.
There was a problem hiding this comment.
There is no need to convince me otherwise if you decide to not take my suggestion, the way you did is fine too.
No description provided.