Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement allow account to create proposal once totalVotingPower is sufficient #384

Conversation

LordCheta
Copy link
Contributor

This PR fixes a bug that incorrectly uses an account's voting balance instead of total voting power (balance + delegated) to check if a proposal can be created

Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Freshenext Freshenext merged commit ae4a0bf into develop Nov 20, 2024
6 checks passed
@Freshenext Freshenext deleted the refactor/create_proposal_when_totalVotingPower_is_sufficient branch November 20, 2024 15:26
shenshin pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants